Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support optional authentication for rule oas3-operation-security-defined #895

Merged
merged 6 commits into from
Jan 9, 2020
Merged

fix: support optional authentication for rule oas3-operation-security-defined #895

merged 6 commits into from
Jan 9, 2020

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Jan 7, 2020 •
edited
Loading

Support optional authentication for rule oas3-operation-security-defined.

Fixes #892

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@m-mohr m-mohr mentioned this pull request Jan 7, 2020
Closed
@m-mohr
Copy link
Contributor Author

m-mohr commented Jan 7, 2020 •
edited
Loading

Not sure why the CI fails for this simple documentation change in ea8c66f. Can someone assist?

@nulltoken
Copy link
Contributor

Not sure why the CI fails for this simple documentation change in ea8c66f. Can someone assist?

image

image

@m-mohr Looks like a unrelated transient network issue. Amending your latest commit with no change, then issuing a git push --force-with-lease should force the CI to run another build.

@m-mohr m-mohr requested a review from nulltoken January 9, 2020 10:45
P0lip
P0lip reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to the test.
Besides that, looking good!

test-harness/scenarios/operation-security-defined.oas3.scenario Show resolved Hide resolved
test-harness/scenarios/operation-security-defined.oas3.scenario Outdated Show resolved Hide resolved
@P0lip P0lip changed the title Support optional authentication for rule oas3-operation-security-defined fix: support optional authentication for rule oas3-operation-security-defined Jan 9, 2020
@m-mohr @P0lip
Apply suggestions from code review
6ea8e57 
Co-Authored-By: Jakub Rożek <jakub@rozek.tech>
@m-mohr
Copy link
Contributor Author

m-mohr commented Jan 9, 2020

@P0lip Okay, I applied the requested changes.

@m-mohr m-mohr requested a review from P0lip January 9, 2020 16:33
@P0lip P0lip merged commit 32af139 into stoplightio:develop Jan 9, 2020
@nulltoken
Copy link
Contributor

@m-mohr 🎉 It's in. Thanks a lot!

@m-mohr m-mohr deleted the patch-1 branch January 10, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0lip P0lip P0lip approved these changes

@philsturgeon philsturgeon Awaiting requested review from philsturgeon

@nulltoken nulltoken Awaiting requested review from nulltoken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oas3-operation-security-defined: Optional authentication not supported
3 participants
@m-mohr @nulltoken @P0lip